Skip to content

Fix fumadocs component styling: Import ObjectUI components CSS #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Jan 23, 2026
Merged

Fix fumadocs component styling: Import ObjectUI components CSS #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320ebd8
Initial plan
Copilot Jan 23, 2026
c38e833
Fix fumadocs styling: Import ObjectUI components CSS for proper butto…
Copilot Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/site/app/components/InteractiveDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const pluginsLoading = typeof window !== 'undefined'
import('@object-ui/plugin-charts'),
import('@object-ui/plugin-kanban'),
import('@object-ui/plugin-markdown'),
import('@object-ui/plugin-object'),
// import('@object-ui/plugin-object'), // Temporarily disabled due to missing dependency
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Temporarily disabled due to missing dependency" is misleading. The @object-ui/data-objectql package exists in the monorepo (packages/data-objectql/), is properly listed in plugin-object's package.json dependencies (line 50), and is only used for type imports in the plugin-object source code.

If there is a genuine build or runtime issue causing this to be disabled, the comment should specify the actual error or problem encountered rather than claiming the dependency is missing.

Suggested change
// import('@object-ui/plugin-object'), // Temporarily disabled due to missing dependency
// import('@object-ui/plugin-object'), // Temporarily disabled pending plugin integration

Copilot uses AI. Check for mistakes.
])
: Promise.resolve([]);

Expand Down
2 changes: 1 addition & 1 deletion apps/site/app/components/ObjectUIProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if (typeof window !== 'undefined') {
import('@object-ui/plugin-charts');
import('@object-ui/plugin-kanban');
import('@object-ui/plugin-markdown');
import('@object-ui/plugin-object');
// import('@object-ui/plugin-object'); // Temporarily disabled due to missing dependency
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Temporarily disabled due to missing dependency" is misleading. The @object-ui/data-objectql package exists in the monorepo (packages/data-objectql/), is properly listed in plugin-object's package.json dependencies (line 50), and is only used for type imports in the plugin-object source code.

If there is a genuine build or runtime issue causing this to be disabled, the comment should specify the actual error or problem encountered rather than claiming the dependency is missing.

Suggested change
// import('@object-ui/plugin-object'); // Temporarily disabled due to missing dependency
// import('@object-ui/plugin-object'); // Temporarily disabled pending resolution of plugin issues

Copilot uses AI. Check for mistakes.
}

export function ObjectUIProvider({ children }: { children: React.ReactNode }) {
Expand Down
1 change: 1 addition & 0 deletions apps/site/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import './global.css';
import '@object-ui/components/style.css';
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import creates CSS duplication. The components package's index.css (which gets built to dist/index.css) contains '@import tailwindcss' and defines all theme variables (packages/components/src/index.css lines 1-109). The site's global.css already imports tailwindcss and defines the same theme variables (lines 1-104).

With Tailwind 4's @source directive, global.css already scans the components package for classes (line 7: '@source ../../packages/components/src/**/*.{ts,tsx}'). This should generate all needed component styles without requiring a separate CSS import.

However, there's a tradeoff: the components package needs standalone CSS for external consumers. If removing this import causes styling issues, it suggests the @source scanning may not be working correctly. Consider verifying that Tailwind 4's @source properly processes the component classes, or document why both imports are necessary despite the duplication.

Suggested change
import '@object-ui/components/style.css';

Copilot uses AI. Check for mistakes.
import { RootProvider } from 'fumadocs-ui/provider/next';
import { ObjectUIProvider } from './components/ObjectUIProvider';
import type { ReactNode } from 'react';
Expand Down
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"import": "./dist/index.js",
"require": "./dist/index.umd.cjs"
},
"./dist/style.css": "./dist/style.css"
"./style.css": "./dist/index.css"
},
"scripts": {
"build": "vite build",
Expand Down
Loading