Fix no-case-declarations ESLint error in plugin-aggrid#276
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update action job steps for improved execution
Fix no-case-declarations ESLint error in plugin-aggrid
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI failure caused by an ESLint no-case-declarations rule violation in the ObjectAgGridImpl.tsx file. The issue occurs when a lexical declaration (const, let, or class) is used directly within a case block without braces, which can lead to unexpected scope behavior across different cases.
Changes:
- Added braces to the
case 'number':block to properly scope theconst precisiondeclaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failing on ESLint rule
no-case-declarationsinObjectAgGridImpl.tsx:553.Changes
Wrapped
case 'number':block in braces to properly scopeconst precisiondeclaration.Lexical declarations in case blocks require braces per ESLint rules to prevent scope leakage across cases.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.