Fix no-case-declarations ESLint error in plugin-aggrid#278
Merged
hotlong merged 2 commits intocopilot/implement-metadata-cachingfrom Jan 30, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix action step error in build process
Fix no-case-declarations ESLint error in plugin-aggrid
Jan 30, 2026
de7fe20
into
copilot/implement-metadata-caching
7 of 9 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an ESLint no-case-declarations violation in the AG Grid plugin by wrapping a switch case block with braces. The ESLint rule requires lexical declarations (const, let, class) at the top level of case clauses to be wrapped in braces to create a proper block scope.
Changes:
- Added braces to the
case 'number':block inapplyFieldTypeFormattingfunction to properly scope theconst precisiondeclaration
Contributor
|
✅ All checks passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint rule
no-case-declarationsrequires lexical declarations in switch case blocks to be wrapped in braces.Changes:
case 'number':block with braces inObjectAgGridImpl.tsx:552-561Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.