Fix SELECT * incorrectly included in aggregation-only queries#280
Merged
hotlong merged 2 commits intocopilot/implement-object-and-field-schemasfrom Jan 30, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… present Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update action steps logging for better tracking
Fix SELECT * incorrectly included in aggregation-only queries
Jan 30, 2026
4dcbd1d
into
copilot/implement-object-and-field-schemas
6 of 7 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the QueryASTBuilder where aggregation-only queries incorrectly included a wildcard field (SELECT *) in addition to the aggregation functions. The fix ensures that when a query specifies only aggregations without explicit fields, the generated AST contains only the aggregation fields, aligning with standard SQL semantics.
Changes:
- Modified the
buildSelect()method to conditionally add the wildcard field only when both fields and aggregations are absent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QueryASTBuilder was generating invalid AST by including a wildcard field (
SELECT *) in queries that specified only aggregations without explicit fields. This is semantically incorrect—aggregation queries should select only the aggregated values.Changes
buildSelect()to exclude the wildcard field when aggregations are present but no explicit fields are specifiedelsetoelse if (!query.aggregations || query.aggregations.length === 0)Before/After
This aligns the AST generation with standard SQL semantics where
SELECT COUNT(*), SUM(amount)does not include an additional wildcard field.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.