Fix orphaned JSX causing TypeScript build failure in MasterDetailField#320
Merged
Fix orphaned JSX causing TypeScript build failure in MasterDetailField#320
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ript errors Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update reference for action step in job
Fix orphaned JSX causing TypeScript build failure in MasterDetailField
Feb 1, 2026
Collaborator
|
@copilot fix test and build |
- Fix TypeScript error in apps/console/src/mocks/server.ts by using correct QueryInput structure (where instead of filters) - Fix test failure in plugin-timeline by removing duplicate @testing-library/jest-dom import - Add proper vitest configuration to plugin-timeline for test environment setup Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Contributor
Author
Fixed in commit c8dd773. Changes:
All builds and tests now pass. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript build failures caused by orphaned JSX in the MasterDetailField component and addresses several test configuration issues identified in CI.
Changes:
- Removed duplicate/orphaned JSX closing tags and content in MasterDetailField that was causing TypeScript compilation errors
- Added missing vitest test configuration to plugin-timeline package to align with other packages
- Removed redundant @testing-library/jest-dom import (already present in global setup)
- Fixed InMemoryDriver query structure to use correct API (
objectandwhereproperties)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fields/src/widgets/MasterDetailField.tsx | Removed orphaned JSX code (duplicate closing tags and elements) that was causing TypeScript build failure |
| packages/plugin-timeline/vite.config.ts | Added missing test configuration (globals, environment, setupFiles) to match other packages |
| packages/plugin-timeline/src/ObjectTimeline.msw.test.tsx | Removed redundant @testing-library/jest-dom import already in vitest.setup.ts |
| apps/console/src/mocks/server.ts | Fixed driver.find() call to use correct query structure with object and where properties |
Contributor
📦 Bundle Size Report
Size Limits
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Contributor
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.