Skip to content

Fix ESLint ban-ts-comment violations blocking CI#328

Merged
hotlong merged 2 commits intomainfrom
copilot/fix-action-run-issue-one-more-time
Feb 2, 2026
Merged

Fix ESLint ban-ts-comment violations blocking CI#328
hotlong merged 2 commits intomainfrom
copilot/fix-action-run-issue-one-more-time

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 2, 2026

CI lint failing on @typescript-eslint/ban-ts-comment rule violations. The rule requires @ts-expect-error over @ts-ignore - the former fails compilation if the suppressed error is resolved, preventing stale suppressions.

Changes

Replaced 4 instances of @ts-ignore with @ts-expect-error:

- // @ts-ignore
+ // @ts-expect-error - Schema type mismatch for testing purposes
  schema={schema}

Files updated:

  • packages/plugin-timeline/src/ObjectTimeline.msw.test.tsx
  • packages/plugin-grid/src/ObjectGrid.msw.test.tsx
  • packages/plugin-form/src/ObjectForm.msw.test.tsx
  • packages/cli/src/utils/app-generator.ts
Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21577503496/job/62167909522#step:8:1


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Ready Ready Preview, Comment Feb 2, 2026 5:00am
objectui-components Ready Ready Preview, Comment Feb 2, 2026 5:00am
objectui-crm-app Error Error Feb 2, 2026 5:00am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix action run issue in GitHub workflows Fix ESLint ban-ts-comment violations blocking CI Feb 2, 2026
Copilot AI requested a review from hotlong February 2, 2026 04:49
@hotlong hotlong marked this pull request as ready for review February 2, 2026 04:50
Copilot AI review requested due to automatic review settings February 2, 2026 04:50
@hotlong hotlong merged commit f3fea2e into main Feb 2, 2026
4 of 7 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes ESLint ban-ts-comment violations that were blocking CI by replacing @ts-ignore directives with @ts-expect-error. The key advantage of @ts-expect-error is that it will fail compilation if the suppressed error is resolved, preventing stale type suppressions from accumulating in the codebase.

Changes:

  • Replaced 4 instances of @ts-ignore with @ts-expect-error and added explanatory comments
  • Updated test files to comply with TypeScript ESLint best practices
  • All suppressions now include descriptive comments explaining why they're needed

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/plugin-timeline/src/ObjectTimeline.msw.test.tsx Updated TypeScript suppression for intentional schema type mismatch in test
packages/plugin-grid/src/ObjectGrid.msw.test.tsx Updated TypeScript suppression for importing from examples directory
packages/plugin-form/src/ObjectForm.msw.test.tsx Updated TypeScript suppression for importing from examples directory
packages/cli/src/utils/app-generator.ts Updated TypeScript suppression for dynamic icon lookup from Lucide icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants