Fix ESLint ban-ts-comment violations blocking CI#328
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix action run issue in GitHub workflows
Fix ESLint ban-ts-comment violations blocking CI
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ESLint ban-ts-comment violations that were blocking CI by replacing @ts-ignore directives with @ts-expect-error. The key advantage of @ts-expect-error is that it will fail compilation if the suppressed error is resolved, preventing stale type suppressions from accumulating in the codebase.
Changes:
- Replaced 4 instances of
@ts-ignorewith@ts-expect-errorand added explanatory comments - Updated test files to comply with TypeScript ESLint best practices
- All suppressions now include descriptive comments explaining why they're needed
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-timeline/src/ObjectTimeline.msw.test.tsx | Updated TypeScript suppression for intentional schema type mismatch in test |
| packages/plugin-grid/src/ObjectGrid.msw.test.tsx | Updated TypeScript suppression for importing from examples directory |
| packages/plugin-form/src/ObjectForm.msw.test.tsx | Updated TypeScript suppression for importing from examples directory |
| packages/cli/src/utils/app-generator.ts | Updated TypeScript suppression for dynamic icon lookup from Lucide icons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI lint failing on
@typescript-eslint/ban-ts-commentrule violations. The rule requires@ts-expect-errorover@ts-ignore- the former fails compilation if the suppressed error is resolved, preventing stale suppressions.Changes
Replaced 4 instances of
@ts-ignorewith@ts-expect-error:Files updated:
packages/plugin-timeline/src/ObjectTimeline.msw.test.tsxpackages/plugin-grid/src/ObjectGrid.msw.test.tsxpackages/plugin-form/src/ObjectForm.msw.test.tsxpackages/cli/src/utils/app-generator.tsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.