fix: prevent examples and apps from publishing to npm#386
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Update .changeset/config.json to correctly ignore example packages (changed from @examples/* to @object-ui/example-*) - Add @object-ui/console and @object-ui/site to changeset ignore list - Mark @object-ui/console as private in package.json - Remove publishConfig from @object-ui/console as it's now private All example packages already have "private": true All publishable packages are at unified version 0.5.0 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the changeset configuration to prevent examples and apps from being published to npm. The previous ignore pattern @examples/* didn't match actual package names, which follow the @object-ui/example-* convention. Additionally, the console app was configured for publishing despite being a runtime application.
Changes:
- Fixed changeset ignore pattern from
@examples/*to@object-ui/example-*to correctly match example package names - Added
@object-ui/consoleand@object-ui/siteto the changeset ignore list - Marked
@object-ui/consoleas private and removed itspublishConfig
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.changeset/config.json |
Updated ignore patterns to correctly exclude example packages and apps from publishing |
apps/console/package.json |
Marked package as private and removed unnecessary publishConfig |
| { | ||
| "name": "@object-ui/console", | ||
| "version": "0.5.0", | ||
| "private": true, |
There was a problem hiding this comment.
The console package is now marked as private, but its README still documents how to import it as a plugin with import ConsolePlugin from '@object-ui/console'. This documentation should be updated to reflect that the package is not published to npm and is only intended for internal use. Consider updating the README to clarify the intended usage pattern for this runtime application.
Changeset config was using incorrect ignore pattern (
@examples/*) that didn't match actual package names (@object-ui/example-*). Console app was marked for publishing despite being a runtime application, not a library.Changes
.changeset/config.json@examples/*→@object-ui/example-*@object-ui/console,@object-ui/siteapps/console/package.json"private": truepublishConfig(no longer needed)Impact
Will NOT publish (7 packages):
@object-ui/example-*@object-ui/console,@object-ui/siteWill publish (26 packages):
/packages/*at unified version0.5.0Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.