Skip to content

fix: use turbo build in e2e CI job to resolve missing package artifacts #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Feb 11, 2026
Merged

fix: use turbo build in e2e CI job to resolve missing package artifacts #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d756e97
Initial plan
Copilot Feb 11, 2026
5b44548
fix: use turbo build in playwright webServer and add build step to CI…
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Build packages and console
run: pnpm turbo run build --filter='./packages/*' --filter='./apps/console'

Comment on lines +148 to +150
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step runs a full Turbo build right before E2E, but Playwright's webServer.command also triggers a Turbo build. Unless you make the Playwright command skip building on CI, this duplicates work and can significantly increase CI duration. Either drop this step and keep the webServer build, or keep this step and adjust the Playwright config to only run preview on CI.

Copilot uses AI. Check for mistakes.
- name: Install Playwright browsers
run: pnpm exec playwright install --with-deps chromium

Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default defineConfig({
* caused by build-time errors (broken imports, missing polyfills, etc.).
*/
webServer: {
command: 'pnpm --filter @object-ui/console build && pnpm --filter @object-ui/console preview --port 4173',
command: 'pnpm turbo run build --filter=@object-ui/console && pnpm --filter @object-ui/console preview --port 4173',
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This webServer.command always runs a Turbo build, but the CI workflow also added an explicit Turbo build step before Playwright. That means CI will build twice (once in the workflow step and again here), increasing job time and potentially pushing against the 180s webServer timeout. Consider making the command conditional (CI: run only preview; local: run turbo build && preview), or remove the explicit build step from the workflow and rely on the webServer build alone.

Suggested change
command: 'pnpm turbo run build --filter=@object-ui/console && pnpm --filter @object-ui/console preview --port 4173',
command: process.env.CI
? 'pnpm --filter @object-ui/console preview --port 4173'
: 'pnpm turbo run build --filter=@object-ui/console && pnpm --filter @object-ui/console preview --port 4173',

Copilot uses AI. Check for mistakes.
url: 'http://localhost:4173',
reuseExistingServer: !process.env.CI,
timeout: 180 * 1000,
Expand Down
Loading