Skip to content

[WIP] Address critical gaps in test coverage and performance#439

Merged
hotlong merged 13 commits intomainfrom
copilot/improve-test-coverage-i18n
Feb 11, 2026
Merged

[WIP] Address critical gaps in test coverage and performance#439
hotlong merged 13 commits intomainfrom
copilot/improve-test-coverage-i18n

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026 •
edited
Loading

  • P0: Internationalization - Integrate @object-ui/i18n into @object-ui/react for built-in i18n support
    • Add @object-ui/i18n as workspace dependency to @object-ui/react
    • Re-export full i18n API (I18nProvider, useObjectTranslation, createI18n, formatters, types) from @object-ui/react
    • Users can now import { I18nProvider, useObjectTranslation } from '@object-ui/react'
  • P0: Performance - Bundle size optimizations via tree-shaking
    • Add sideEffects: false to @object-ui/types, @object-ui/core, @object-ui/i18n, @object-ui/layout
    • Enables bundlers to tree-shake unused exports, reducing bundle size
  • P0: Test Coverage - Comprehensive tests added across packages
    • useExpression + useCondition hooks (0% → tested)
    • useDiscovery hook (0% → tested)
    • useActionRunner hook (42% → tested)
    • ActionContext (ActionProvider, useAction, useHasActionProvider) (54% → tested)
    • i18n provider (I18nProvider, useObjectTranslation, useI18nContext) (new tests)
    • LazyPluginLoader (preloadPlugin, errorFallback, retry) (54% → tested)
    • Timeline renderer (vertical, horizontal, gantt) (15% → tested)
    • SortUI component (36% → tested)
    • FilterUI component (39% → tested)
    • VirtualGrid component (5% → tested)
    • Raised coverage thresholds: lines 61→66, functions 43→55, branches 40→50, statements 60→65

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link

vercel bot commented Feb 11, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Error Error Feb 11, 2026 3:22am
objectui-console Error Error Feb 11, 2026 3:22am
objectui-storybook Error Error Feb 11, 2026 3:22am

Request Review

Copilot AI and others added 7 commits February 11, 2026 02:10
@hotlong
feat: integrate i18n into @object-ui/react and add sideEffects declar…
5cb638f 
…ations for tree-shaking

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add tests for useExpression and useCondition hooks
6f89ff1 
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add tests for useDiscovery hook
b6d0c82 
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add tests for useActionRunner hook
1a636c1 
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add ActionContext tests for ActionProvider, useAction, and useHasActi…
dc56bd9 
…onProvider

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add provider.test.tsx for @object-ui/i18n React integration
7454ba7 
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add test coverage for LazyPluginLoader: preloadPlugin, errorFallback,…
9e964d1 
… retries=0, retry-then-succeed

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI and others added 2 commits February 11, 2026 02:29
@hotlong
Add test file for timeline renderer component (packages/plugin-timeli…
eb91925 
…ne/src/__tests__/renderer.test.tsx)

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add SortUI component test suite
a4ae6dc 
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add FilterUI component tests covering rendering, values, layout, and …
5ad981c 
…callbacks

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
Add comprehensive VirtualGrid test suite in __tests__/VirtualGrid.tes…
508bcc2 
…t.tsx

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong
chore: raise coverage thresholds after adding comprehensive tests
3ffdb40 
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong hotlong marked this pull request as ready for review February 11, 2026 02:51
Copilot AI review requested due to automatic review settings February 11, 2026 02:51
@hotlong hotlong merged commit 371503a into main Feb 11, 2026
10 of 18 checks passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 11, 2026
View reviewed changes
packages/plugin-view/src/__tests__/FilterUI.test.tsx
// -------------------------------------------------------------------------
describe('inline layout', () => {
it('renders the filter form inline by default', () => {
const { container } = render(<FilterUI schema={makeSchema()} />);

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable container.

Copilot Autofix

AI 3 days ago

In general, to fix an unused variable warning, either remove the variable declaration or start using the variable meaningfully. Here, the render call is needed, but the container binding is not. The safest, behavior-preserving fix is to call render without destructuring its return value, since the test body uses only screen APIs.

Concretely, in packages/plugin-view/src/__tests__/FilterUI.test.tsx, in the first test inside the "inline layout" describe block (around line 175), replace const { container } = render(<FilterUI schema={makeSchema()} />); with just render(<FilterUI schema={makeSchema()} />);. No additional imports or helper methods are required.

Suggested changeset 1
packages/plugin-view/src/__tests__/FilterUI.test.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/plugin-view/src/__tests__/FilterUI.test.tsx b/packages/plugin-view/src/__tests__/FilterUI.test.tsx
--- a/packages/plugin-view/src/__tests__/FilterUI.test.tsx
+++ b/packages/plugin-view/src/__tests__/FilterUI.test.tsx
@@ -172,7 +172,7 @@
   // -------------------------------------------------------------------------
   describe('inline layout', () => {
     it('renders the filter form inline by default', () => {
-      const { container } = render(<FilterUI schema={makeSchema()} />);
+      render(<FilterUI schema={makeSchema()} />);
 
       // Labels should be visible
       expect(screen.getByText('Status')).toBeInTheDocument();
EOF
@@ -172,7 +172,7 @@
// -------------------------------------------------------------------------
describe('inline layout', () => {
it('renders the filter form inline by default', () => {
const { container } = render(<FilterUI schema={makeSchema()} />);
render(<FilterUI schema={makeSchema()} />);

// Labels should be visible
expect(screen.getByText('Status')).toBeInTheDocument();
Copilot is powered by AI and may make mistakes. Always verify output.
Copilot AI reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses critical gaps in test coverage, integrates internationalization support, and implements performance optimizations through tree-shaking. The changes increase test coverage thresholds from lines: 61%→66%, functions: 43%→55%, branches: 40%→50%, statements: 60%→65%, supported by comprehensive test additions across hooks, contexts, and plugin components.

Changes:

  • Added comprehensive test coverage for 10+ previously untested components (useExpression, useDiscovery, useActionRunner, ActionContext, i18n provider, LazyPluginLoader, timeline, SortUI, FilterUI, VirtualGrid)
  • Integrated @object-ui/i18n into @object-ui/react, re-exporting the full i18n API for built-in internationalization support
  • Added sideEffects: false to package.json files to enable tree-shaking in bundlers, reducing bundle size

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vitest.config.mts Increased coverage thresholds to reflect improved test coverage
pnpm-lock.yaml Updated lock file with i18n dependency resolution
packages/types/package.json Added sideEffects: false for tree-shaking
packages/core/package.json Added sideEffects: false for tree-shaking
packages/i18n/package.json Added sideEffects: false for tree-shaking
packages/layout/package.json ⚠️ Critical Issue: Added sideEffects: false despite module-level registration side effects
packages/react/package.json Added @object-ui/i18n workspace dependency
packages/react/src/index.ts Re-exported full i18n API from @object-ui/i18n
packages/react/src/hooks/tests/useExpression.test.ts New comprehensive tests for useExpression and useCondition hooks
packages/react/src/hooks/tests/useDiscovery.test.tsx New comprehensive tests for useDiscovery hook including error handling and cleanup
packages/react/src/hooks/tests/useActionRunner.test.ts New comprehensive tests for useActionRunner hook covering all execution paths
packages/react/src/context/tests/ActionContext.test.tsx New comprehensive tests for ActionProvider, useAction, and useHasActionProvider
packages/react/src/tests/LazyPluginLoader.test.tsx Added tests for preloadPlugin, errorFallback, and retry mechanisms
packages/i18n/src/tests/provider.test.tsx New comprehensive tests for i18n provider and hooks
packages/plugin-view/src/tests/SortUI.test.tsx New comprehensive tests covering all SortUI variants and behaviors
packages/plugin-view/src/tests/FilterUI.test.tsx New comprehensive tests covering all FilterUI layouts and filter types
packages/plugin-timeline/src/tests/renderer.test.tsx New comprehensive tests for timeline renderer (vertical, horizontal, gantt)
packages/plugin-grid/src/tests/VirtualGrid.test.tsx New comprehensive tests for VirtualGrid with proper virtualizer mocking
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

packages/layout/package.json
"name": "@object-ui/layout",
"version": "0.5.0",
"type": "module",
"sideEffects": false,
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting sideEffects: false is incorrect for this package. The entry point src/index.ts has module-level side effects (calls registerLayout() at lines 53-57 to register components in ComponentRegistry). If bundlers tree-shake this module due to sideEffects: false, the layout components will not be registered and will fail at runtime. Either remove this field or set it to true, or move the registration call out of the module-level scope.

Suggested change
"sideEffects": false,
"sideEffects": true,

Copilot uses AI. Check for mistakes.
packages/plugin-view/src/__tests__/FilterUI.test.tsx
// -------------------------------------------------------------------------
describe('inline layout', () => {
it('renders the filter form inline by default', () => {
const { container } = render(<FilterUI schema={makeSchema()} />);
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable container.

Suggested change
const { container } = render(<FilterUI schema={makeSchema()} />);
render(<FilterUI schema={makeSchema()} />);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@hotlong hotlong

Copilot code review Copilot

Labels

configuration dependencies package: core package: react package: types plugin tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hotlong