fix: move console app dependencies to devDependencies#503
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The @object-ui/console package publishes plugin.ts (which only uses Node.js built-ins: url, path, fs) and pre-built dist/ static assets. All React, UI, and example dependencies are only needed at build time, not when consumers install the package. Moving them to devDependencies ensures `npm install @object-ui/console` succeeds without pulling in workspace-only packages. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR makes @object-ui/console installable from npm by removing workspace:* runtime dependencies (and other build-time inputs) from dependencies, aligning the published artifact (plugin.ts + prebuilt dist/) with a “no runtime deps” package model.
Changes:
- Moved
apps/console/package.jsonruntime dependencies intodevDependenciesso npm consumers don’t attempt to resolve unpublishedworkspace:*packages. - Updated
pnpm-lock.yamlto reflect the dependency-type move and resulting resolution graph changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/console/package.json | Moves all prior runtime deps to devDependencies to avoid npm install failures on workspace:* entries. |
| pnpm-lock.yaml | Updates lockfile importer entries for apps/console (and prunes/resolves related graph changes). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| "@object-ui/types": "workspace:*", | ||
| "@objectstack/cli": "^3.0.2", | ||
| "@objectstack/client": "^3.0.2", | ||
| "@objectstack/driver-memory": "^3.0.2", | ||
| "@objectstack/objectql": "^3.0.2", | ||
| "@objectstack/plugin-msw": "^3.0.2", | ||
| "@objectstack/runtime": "^3.0.2", | ||
| "@objectstack/spec": "^3.0.2", |
There was a problem hiding this comment.
The PR description says plugin.ts uses exclusively Node.js built-ins, but apps/console/plugin.ts does a runtime import('@hono/node-server/serve-static'). With this package now having no runtime deps, that import will only succeed if the host app provides @hono/node-server; otherwise it always falls back.
Suggested fix: either (a) update the PR description / package docs to explicitly call @hono/node-server an optional host-provided optimization, or (b) declare @hono/node-server as an optional peer/optional dependency if you want the fast path to work by default.
@object-ui/consoleis uninstallable from npm because it declares 30+workspace:*packages (including unpublished examples) as runtimedependencies. The published package only shipsplugin.ts+dist/static assets —plugin.tsuses exclusively Node.js built-ins (url,path,fs), anddist/is a fully bundled Vite SPA.dependencies→devDependenciessince every package is a build-time input onlynpm install @object-ui/consolein external projects💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.