fix: remove unused CJS require of ESM-only @storybook/test-runner#510
Merged
fix: remove unused CJS require of ESM-only @storybook/test-runner#510
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…r config Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add patch for code correction
fix: remove unused CJS require of ESM-only @storybook/test-runner
Feb 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical ESM/CJS compatibility issue that was causing all 78 Storybook test suites to fail. The @storybook/test-runner@0.24.2 package is ESM-only, but .storybook/test-runner.cjs was attempting to require() it, resulting in "Must use import to load ES Module" errors.
Changes:
- Removed unused
require('@storybook/test-runner')that importedgetStoryContext(never referenced in the code) - Removed unnecessary
require('jest-snapshot')that importedtoMatchSnapshot(Jest matcher is globally available in test-runner environment, no explicit import needed)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@storybook/test-runner@0.24.2ships as ESM-only ("type": "module")..storybook/test-runner.cjswasrequire()-ing it, failing all 78 Storybook test suites on main:require('@storybook/test-runner')—getStoryContextwas imported but never referencedrequire('jest-snapshot')—toMatchSnapshotwas imported but unused (expect().toMatchSnapshot()uses Jest's built-in matcher)No functional change to
prepare,preVisit, orpostVisithooks.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.