-
Notifications
You must be signed in to change notification settings - Fork 2
Add field type evaluation for form designer to ROADMAP_DESIGNER.md #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| # Designer UX Analysis & Improvement Plan | ||||||
|
|
||||||
| > **Last Updated:** February 12, 2026 | ||||||
| > **Last Updated:** February 16, 2026 | ||||||
| > **Package:** `@object-ui/plugin-designer` | ||||||
| > **Source:** `packages/plugin-designer/src/` | ||||||
|
|
||||||
|
|
@@ -500,6 +500,377 @@ This is the **most complete** designer: | |||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## 10. Field Type Evaluation for Form Designer | ||||||
|
|
||||||
| > **Last Updated:** February 16, 2026 | ||||||
| > **Related Packages:** `@object-ui/fields`, `@object-ui/types`, `@object-ui/plugin-designer` | ||||||
|
|
||||||
| ### 10.1 Overview | ||||||
|
|
||||||
| The `@object-ui/fields` package provides **36 field widget implementations** covering | ||||||
| text, numeric, date/time, selection, file, contact, computed, and visual field types. | ||||||
| The `@object-ui/types` package defines **35 typed metadata interfaces** in | ||||||
|
||||||
| The `@object-ui/types` package defines **35 typed metadata interfaces** in | |
| The `@object-ui/types` package defines **37 typed metadata interfaces** in |
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to line 258 is slightly inaccurate. The actual line where the type is hardcoded to 'text' is line 260 in DataModelDesigner.tsx. Please update the line reference from 258 to 260.
| **Current state:** When a field is added via `handleAddField` (`DataModelDesigner.tsx:258`), | |
| **Current state:** When a field is added via `handleAddField` (`DataModelDesigner.tsx:260`), |
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed palette addition code has a type mismatch. The code uses icon: ft.icon.name where ft.icon is a LucideIcon component type. However, DesignerPaletteItem.icon is typed as string (see @object-ui/types/designer.ts:118). LucideIcon components don't have a .name property that provides a string identifier. Consider one of these alternatives: (1) use the field type name as the icon identifier (icon: ft.type), (2) add a separate iconName field to DesignerFieldTypeOption, or (3) if you need the actual icon component, you'll need to change how palette items handle icons in the designer implementation.
| icon: ft.icon.name, | |
| icon: ft.type, |
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of missing field types in mapFieldTypeToFormType is incomplete. Based on the code in @object-ui/fields/src/index.tsx (lines 583-629), the function currently maps 24 out of 37 field types. The missing types are: user, object, vector, grid, color, slider, rating, code, avatar, address, geolocation, signature, and qrcode (13 types total, not 9). Please update the list to include all missing types or clarify which subset is considered priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document states "36 field widget implementations" but the actual count from @object-ui/fields/src/widgets/ directory and the FieldMetadata union type in @object-ui/types/field-types.ts is 37 field types (including all types listed in the tables below). Please update this number to 37.