Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- ViewConfigPanel.test.tsx: remove type arg from untyped React.useState - view-config-schema.test.tsx: prefix unused specProp with underscore - AppManagementPage.tsx: remove unused Loader2 import - PermissionManagementPage.tsx: remove unused Card, CardContent imports - view-config-schema.tsx: remove unused SectionHeader import, prefix unused params (fieldOptions, fieldSelectWithNone, draft) with underscore - RecordActivityTimeline.tsx: prefix unused loading param with underscore - ROADMAP.md: update build count 42/42 → 43/43 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all CI errors in build process
fix: resolve CI build TypeScript errors (TS2347, TS6133)
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves 10 TypeScript strict-mode compilation errors (TS2347, TS6133) that were causing CI build failures. The fixes follow TypeScript best practices: removing genuinely unused imports, prefixing unused parameters with underscore, and removing type arguments from untyped function calls in vitest mocks.
Changes:
- Removed 4 unused imports (Loader2, Card, CardContent, SectionHeader) that were triggering TS6133 errors
- Prefixed 6 unused function parameters with underscore (_) to suppress TS6133 warnings while preserving function signatures
- Fixed TS2347 error by removing type argument from React.useState in vitest mock where React is obtained via untyped require() call
- Updated ROADMAP.md build count from 42/42 to 43/43 to reflect CI status
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/console/src/pages/system/AppManagementPage.tsx | Removed unused Loader2 import |
| apps/console/src/pages/system/PermissionManagementPage.tsx | Removed unused Card and CardContent imports |
| apps/console/src/utils/view-config-schema.tsx | Removed unused SectionHeader import; prefixed 3 unused parameters (_fieldOptions, _fieldSelectWithNone, _draft) |
| apps/console/src/tests/view-config-schema.test.tsx | Prefixed unused _specProp parameter in test loop |
| packages/plugin-detail/src/RecordActivityTimeline.tsx | Prefixed unused loading parameter (_loading) that's shadowed by internal isLoadingMore state |
| apps/console/src/tests/ViewConfigPanel.test.tsx | Removed type argument from React.useState<Record<string, boolean>>({}) to fix TS2347 in mock context |
| ROADMAP.md | Updated build status from 42/42 to 43/43 passing builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console build failing due to 10 TypeScript strict-mode errors — unused imports, unused parameters, and a type argument on an untyped
require('react')call inside a vitest mock.Unused imports removed
Loader2fromAppManagementPage.tsxCard,CardContentfromPermissionManagementPage.tsxSectionHeaderfromview-config-schema.tsxUnused parameters prefixed with
_fieldOptions,fieldSelectWithNone,draftinview-config-schema.tsxbuilder functionsspecPropinview-config-schema.test.tsxloadinginRecordActivityTimeline.tsxUntyped function call fix
Reactis obtained viarequire('react')insidevi.mock, returningany— TS2347 prohibits type arguments on untyped calls.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.