fix: ListView toolbar buttons opt-in by default, remove duplicate record count#889
Merged
fix: ListView toolbar buttons opt-in by default, remove duplicate record count#889
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… count - Change showHideFields/showColor/showDensity from opt-out (!== false) to opt-in (=== true) - Remove duplicate record-count-footer from ObjectView.tsx - Update @default JSDoc in NamedListView and ListViewSchema types - Update 11 tests to match new default behavior - Document fix in ROADMAP.md Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Optimize ListView UI following Airtable style
fix: ListView toolbar buttons opt-in by default, remove duplicate record count
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ListView toolbar defaults to match an Airtable-style “opt-in” behavior for secondary controls and removes a duplicate record count display in the Console ObjectView.
Changes:
- Switched
showHideFields,showColor, andshowDensitytoolbar flags from opt-out (!== false) to opt-in (=== true) inListView. - Updated
@object-ui/typesJSDoc@defaultannotations for the same flags tofalse. - Removed Console
ObjectView’srecord-count-footerto avoid duplicate record count UI (ListView’srecord-count-barremains).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-list/src/ListView.tsx | Makes Hide Fields/Color/Density toolbar buttons opt-in (hidden unless explicitly enabled). |
| packages/types/src/objectql.ts | Updates schema docs to reflect the new opt-in defaults (@default false). |
| packages/plugin-list/src/tests/ListView.test.tsx | Updates tests for the new default toolbar visibility and explicitly enables affected buttons where needed. |
| apps/console/src/components/ObjectView.tsx | Removes duplicate record count footer from ObjectView UI. |
| apps/console/src/tests/ObjectView.test.tsx | Updates test to assert ObjectView no longer renders the footer. |
| ROADMAP.md | Records the change and its rationale/tests in the roadmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
showHideFields,showColor,showDensitytoolbar buttons were visible by default (opt-out), and record count rendered twice—once in ListView'srecord-count-barand again in ObjectView'srecord-count-footer.Toolbar defaults: opt-out → opt-in
packages/plugin-list/src/ListView.tsx— toolbarFlags computationpackages/types/src/objectql.ts—@defaultJSDoc updated tofalseon bothNamedListViewandListViewSchemaDuplicate record count
record-count-footerfromapps/console/src/components/ObjectView.tsx— ListView'srecord-count-baris the single source of truthTests
showX: trueOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.