Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 17, 2026

Fix chart-bar component missing default color property

Problem

Test failure in packages/plugin-charts/src/index.test.ts:

  • Test expects color property in defaultProps to be '#8884d8'
  • Current implementation missing color in defaultProps object (line 69-70)
  • Input definition for color exists (line 57) but lacks defaultValue

Solution Applied

  • Understand the issue from CI logs
  • Locate the failing test and source code
  • Add missing color property to defaultProps in chart-bar registration
  • Add defaultValue to color input definition for consistency
  • Verify the fix by running tests locally - all tests pass
  • Ensure no other components are affected

Changes Made

  1. Added color: '#8884d8' to defaultProps object in chart-bar component registration
  2. Added defaultValue: '#8884d8' to color input definition

Test Results

✅ All 11 tests in packages/plugin-charts/src/index.test.ts pass
✅ All 100 tests across the entire project pass

Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21088836829/job/60657230181#step:7:1


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Added missing color default value (#8884d8) to:
- defaultProps object (required by test)
- input definition defaultValue (for consistency)

This fixes the failing test in packages/plugin-charts/src/index.test.ts
that expected color to be '#8884d8' in defaultProps.

Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
@github-actions
Copy link

✅ All checks passed!

  • ✅ Type check passed
  • ✅ Tests passed
  • ✅ Lint check completed

@huangyiirene huangyiirene marked this pull request as ready for review January 17, 2026 05:26
@huangyiirene huangyiirene merged commit 3e3942c into copilot/update-objectql-to-latest Jan 17, 2026
3 checks passed
Copilot AI requested a review from huangyiirene January 17, 2026 05:27
Copilot stopped work on behalf of huangyiirene due to an error January 17, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants