Skip to content

feat(plugin-detail): complete remaining roadmap features for detail page #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 4 commits into from
Mar 2, 2026
Merged

feat(plugin-detail): complete remaining roadmap features for detail page #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ed66d3
Initial plan
Copilot Mar 2, 2026
ccd7cda
feat(plugin-detail): implement all 6 roadmap features
Copilot Mar 2, 2026
adb6839
fix(vercel): increase memory limit and reduce turbo concurrency for V…
Copilot Mar 2, 2026
6eb3fbd
fix(vercel): revert vercel.json to original build command
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,13 +1461,13 @@ All 313 `@object-ui/fields` tests pass.
- [x] 2 new DetailView i18n fallback tests (Record not found text, Related heading)
- [x] Updated DetailSection tests for new empty value styling

**Remaining (future PRs):**
- [ ] Auto-discover related lists from objectSchema reference fields
- [ ] Tab layout (Details/Related/Activity) for detail page
- [ ] Related list row-level Edit/Delete quick actions
- [ ] Related list pagination, sorting, filtering
- [ ] Collapsible section groups
- [ ] Header highlight area with key fields
**Completed:**
- [x] Auto-discover related lists from objectSchema reference fields
- [x] Tab layout (Details/Related/Activity) for detail page
- [x] Related list row-level Edit/Delete quick actions
- [x] Related list pagination, sorting, filtering
- [x] Collapsible section groups
- [x] Header highlight area with key fields

---

Expand Down
285 changes: 230 additions & 55 deletions packages/plugin-detail/src/DetailView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ import {
TooltipContent,
TooltipProvider,
TooltipTrigger,
Tabs,
TabsList,
TabsTrigger,
TabsContent,
} from '@object-ui/components';
import {
ArrowLeft,
Expand All @@ -40,6 +44,8 @@ import {
import { DetailSection } from './DetailSection';
import { DetailTabs } from './DetailTabs';
import { RelatedList } from './RelatedList';
import { SectionGroup } from './SectionGroup';
import { HeaderHighlight } from './HeaderHighlight';
import { RecordComments } from './RecordComments';
import { ActivityTimeline } from './ActivityTimeline';
import { SchemaRenderer } from '@object-ui/react';
Expand Down Expand Up @@ -288,6 +294,40 @@ export const DetailView: React.FC<DetailViewProps> = ({
return () => document.removeEventListener('keydown', handler);
}, [schema.recordNavigation]);

// Auto-discover related lists from objectSchema reference fields
const discoveredRelated = React.useMemo(() => {
if (!schema.autoDiscoverRelated || !objectSchema?.fields) return [];
// Only auto-discover when no explicit related config is provided
if (schema.related && schema.related.length > 0) return [];
const refs: Array<{ title: string; type: 'list' | 'grid' | 'table'; objectName: string; referenceField: string }> = [];
const fields = objectSchema.fields;
for (const [fieldName, fieldDef] of Object.entries<any>(fields)) {
if (
fieldDef &&
(fieldDef.type === 'lookup' || fieldDef.type === 'master_detail') &&
fieldDef.reference_to
) {
refs.push({
title: fieldDef.label || fieldName.charAt(0).toUpperCase() + fieldName.slice(1),
type: 'table',
objectName: fieldDef.reference_to,
referenceField: fieldName,
});
}
}
return refs;
}, [schema.autoDiscoverRelated, schema.related, objectSchema]);

// Merge explicit and auto-discovered related lists
const effectiveRelated = React.useMemo(() => {
if (schema.related && schema.related.length > 0) return schema.related;
return discoveredRelated.map((r) => ({
title: r.title,
type: r.type,
data: [] as any[],
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoDiscoverRelated computes objectName and referenceField for discovered relations, but effectiveRelated discards them and returns { title, type, data: [] } with no api or other metadata. As a result, the “auto-discovered related lists” render as empty lists and can’t be fetched via dataSource. Consider extending the DetailViewSchema['related'] item type to carry the discovered metadata (e.g., objectName/referenceField or a generated api) and have RelatedList/DetailView use it to load real related records.

Suggested change
data: [] as any[],
objectName: r.objectName,
referenceField: r.referenceField,

Copilot uses AI. Check for mistakes.
}));
}, [schema.related, discoveredRelated]);

if (loading || schema.loading) {
return (
<div className={cn('space-y-4', className)}>
Expand Down Expand Up @@ -528,70 +568,205 @@ export const DetailView: React.FC<DetailViewProps> = ({
</div>
)}

{/* Sections */}
{schema.sections && schema.sections.length > 0 && (
<div className="space-y-3 sm:space-y-4">
{schema.sections.map((section, index) => (
{/* Header Highlight Area */}
{schema.highlightFields && schema.highlightFields.length > 0 && (
<HeaderHighlight fields={schema.highlightFields} data={data} />
)}

{/* Auto Tabs mode: wrap sections, related, activity into tabs */}
{schema.autoTabs && !schema.tabs?.length ? (
<Tabs defaultValue="details" className="w-full">
<TabsList className="w-full justify-start border-b rounded-none bg-transparent p-0">
<TabsTrigger
value="details"
className="relative rounded-none border-b-2 border-transparent data-[state=active]:border-primary data-[state=active]:bg-transparent"
>
{t('detail.details')}
</TabsTrigger>
{effectiveRelated.length > 0 && (
<TabsTrigger
value="related"
className="relative rounded-none border-b-2 border-transparent data-[state=active]:border-primary data-[state=active]:bg-transparent"
>
<span className="flex items-center gap-1.5">
{t('detail.related')}
<Badge variant="secondary" className="text-xs">{effectiveRelated.length}</Badge>
</span>
</TabsTrigger>
)}
{schema.activities && schema.activities.length > 0 && (
<TabsTrigger
value="activity"
className="relative rounded-none border-b-2 border-transparent data-[state=active]:border-primary data-[state=active]:bg-transparent"
>
<span className="flex items-center gap-1.5">
{t('detail.activity')}
<Badge variant="secondary" className="text-xs">{schema.activities.length}</Badge>
</span>
</TabsTrigger>
)}
</TabsList>

{/* Details Tab Content */}
<TabsContent value="details" className="mt-4">
<div className="space-y-3 sm:space-y-4">
{/* Section Groups */}
{schema.sectionGroups && schema.sectionGroups.length > 0 && (
schema.sectionGroups.map((group, index) => (
<SectionGroup
key={index}
group={group}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
))
)}
{schema.sections && schema.sections.length > 0 && (
schema.sections.map((section, index) => (
<DetailSection
key={index}
section={section}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
))
)}
{schema.fields && schema.fields.length > 0 && !schema.sections?.length && (
<DetailSection
section={{
fields: schema.fields,
columns: schema.columns,
}}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
)}
{/* Comments in details tab */}
{schema.comments && (
<RecordComments
comments={schema.comments}
onAddComment={schema.onAddComment}
/>
)}
</div>
</TabsContent>

{/* Related Tab Content */}
{effectiveRelated.length > 0 && (
<TabsContent value="related" className="mt-4">
<div className="space-y-4">
{effectiveRelated.map((related, index) => (
<RelatedList
key={index}
title={related.title}
type={related.type}
api={related.api}
data={related.data}
columns={related.columns as any}
dataSource={dataSource}
/>
))}
</div>
</TabsContent>
)}

{/* Activity Tab Content */}
{schema.activities && schema.activities.length > 0 && (
<TabsContent value="activity" className="mt-4">
<ActivityTimeline activities={schema.activities} />
</TabsContent>
)}
</Tabs>
) : (
<>
{/* Section Groups */}
{schema.sectionGroups && schema.sectionGroups.length > 0 && (
<div className="space-y-3 sm:space-y-4">
{schema.sectionGroups.map((group, index) => (
<SectionGroup
key={index}
group={group}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
))}
</div>
)}

{/* Sections */}
{schema.sections && schema.sections.length > 0 && (
<div className="space-y-3 sm:space-y-4">
{schema.sections.map((section, index) => (
<DetailSection
key={index}
section={section}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
))}
</div>
)}

{/* Direct Fields (if no sections) */}
{schema.fields && schema.fields.length > 0 && !schema.sections?.length && (
<DetailSection
key={index}
section={section}
section={{
fields: schema.fields,
columns: schema.columns,
}}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
))}
</div>
)}

{/* Direct Fields (if no sections) */}
{schema.fields && schema.fields.length > 0 && !schema.sections?.length && (
<DetailSection
section={{
fields: schema.fields,
columns: schema.columns,
}}
data={{ ...data, ...editedValues }}
objectSchema={objectSchema}
isEditing={isInlineEditing}
onFieldChange={handleInlineFieldChange}
/>
)}

{/* Tabs */}
{schema.tabs && schema.tabs.length > 0 && (
<DetailTabs tabs={schema.tabs} data={data} />
)}
)}

{/* Tabs */}
{schema.tabs && schema.tabs.length > 0 && (
<DetailTabs tabs={schema.tabs} data={data} />
)}

{/* Related Lists */}
{effectiveRelated.length > 0 && (
<div className="space-y-4">
<h2 className="text-xl font-semibold">{t('detail.related')}</h2>
{effectiveRelated.map((related, index) => (
<RelatedList
key={index}
title={related.title}
type={related.type}
api={related.api}
data={related.data}
columns={related.columns as any}
dataSource={dataSource}
/>
))}
</div>
)}

{/* Related Lists */}
{schema.related && schema.related.length > 0 && (
<div className="space-y-4">
<h2 className="text-xl font-semibold">{t('detail.related')}</h2>
{schema.related.map((related, index) => (
<RelatedList
key={index}
title={related.title}
type={related.type}
api={related.api}
data={related.data}
columns={related.columns as any}
dataSource={dataSource}
{/* Comments */}
{schema.comments && (
<RecordComments
comments={schema.comments}
onAddComment={schema.onAddComment}
/>
))}
</div>
)}

{/* Comments */}
{schema.comments && (
<RecordComments
comments={schema.comments}
onAddComment={schema.onAddComment}
/>
)}
)}

{/* Activity Timeline */}
{schema.activities && schema.activities.length > 0 && (
<ActivityTimeline activities={schema.activities} />
{/* Activity Timeline */}
{schema.activities && schema.activities.length > 0 && (
<ActivityTimeline activities={schema.activities} />
)}
</>
)}

{/* Custom Footer */}
Expand Down
Loading