Fixing es-lint problems#86
Merged
oblador merged 2 commits intooblador:masterfrom Feb 24, 2018
Merged
Conversation
I discovered these by pulling down the project for the first time and running ```bash npm test ``` I also am ignoring the package-lock.json since it showed up when I ran the following: ```bash npm install ```
| # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git | ||
| node_modules | ||
|
|
||
| package-lock.json |
There was a problem hiding this comment.
I think it is common to include package-lock.json in a projects repo. It helps keep dependencies in sync.
Contributor
Author
There was a problem hiding this comment.
i, removed it from .gitignore. Thanks for the catch and reminder.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered these by pulling down the project for the first time and running
npm test