write_req: Close file after writing #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Good point, thanks! Since we don't know if the implementor of a writer will call |
When implementing advanced handlers, it is necessary to know when an upload is done, so further processing can start. The AsyncWrite trait has 3 methods: - poll_write() - poll_flush() - poll_close() Before this patch, poll_write() was called one or more times, so the writer didn't know when a transfer was complete. poll_flush() and poll_close() was never called. This patch flushes and closes the writer upon completion, causing both poll_flush() and poll_close() to be called on the writer. Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
asbjornst
force-pushed
the
close-after-write
branch
from
b453b98 to
8df480e
Compare
Contributor
Author
|
Ok, now it calls flush before close. I my application the flush is just a no-op, as I am using it to synthesize transfers. |
Owner
|
Thank you! Releasing in a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing advanced handlers, it is necessary to know when an upload is done, so further processing can start.
The
AsyncWritetrait has 3 methods:poll_write()poll_flush()poll_close()Before this patch,
poll_write()was called one or more times, so the writer didn't know when a transfer was complete.poll_flush()andpoll_close()was never called.This patch closes the writer upon completion, causing
poll_close()to be called on the writer.