Skip to content

Added multiple MCP server as well as enhanced code structure for Feature file #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added multiple MCP server as well as enhanced code structure for Feature file #7

wants to merge 7 commits into from

Conversation

@shwetapsdet
Copy link
Collaborator

@shwetapsdet shwetapsdet commented Nov 6, 2025

No description provided.

@shwetapsdet shwetapsdet changed the title Updated the github workflow to add OpenAI Key and updated the eval logic Added multiple MCP server as well as enhanced code structure for Feature file Nov 17, 2025
drpebcak
drpebcak approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@drpebcak drpebcak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks ok to me. we should document the values of a lot of these secrets though - its not easy to maintain this right now because i dont know what some of these values are. typically we would put those in 1password. @tybalex can you work with @shwetapsdet to find a solution that ensures we have these recorded somewhere for posterity?

@tybalex
Copy link
Contributor

tybalex commented Nov 17, 2025

mostly looks ok to me. we should document the values of a lot of these secrets though - its not easy to maintain this right now because i dont know what some of these values are. typically we would put those in 1password. @tybalex can you work with @shwetapsdet to find a solution that ensures we have these recorded somewhere for posterity?

yeah I will add the values to 1password.

@drpebcak
wip: run matrix on dispatch from PR
a78c755 
Signed-off-by: Taylor Price <tayworm@gmail.com>
@drpebcak
chore: trigger specific scenarios per mcp server
7d1bfda 
Signed-off-by: Taylor Price <tayworm@gmail.com>
@drpebcak
fix: replace function does not exist
aa93dab 
Signed-off-by: Taylor Price <tayworm@gmail.com>
@drpebcak
fix: close escape sequence
d88daf6 
Signed-off-by: Taylor Price <tayworm@gmail.com>
@drpebcak
Copy link
Contributor

drpebcak commented Nov 20, 2025

@shwetapsdet can you resolve the conflicts here, and then update this PR to incorporate the changes in #8? Once those are in we can change the automation slightly to launch the mcp servers we are adding to the catalog to test.

@shwetapsdet
Copy link
Collaborator Author

shwetapsdet commented Nov 21, 2025

@drpebcak @tybalex, I have resolved the conflicts and also updated this PR to incorporate the changes in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drpebcak drpebcak drpebcak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shwetapsdet @tybalex @drpebcak