fix: verify server actually stopped in stop-server.sh#751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix [stop-server.sh] so it doesn’t report success unless the server process is actually dead (SIGTERM + wait + SIGKILL fallback).
Motivation and Context
[stop-server.sh] previously always returned {"status":"stopped"} after sending SIGTERM, even if the node server kept listening on the port. That made the “stop” command misleading and prevents safe automation or retries (because the PID file was removed even if the process survived).
How Has This Been Tested?
Started the visual companion server (start-server.sh)
Ran stop-server.sh <screen_dir>
Confirmed output is "stopped" only when the process truly exited
Verified with lsof -i : that the server stopped
Confirmed it reports "failed" when the process ignores SIGTERM/SIGKILL
Breaking Changes
No. This is a bug fix and does not change existing behavior except making the stop result accurate.
Types of changes
Checklist
Additional context
This directly addresses issue #729