fix: resolve ESM/CommonJS conflict in brainstorming server #774#784
Closed
sarbojitrana wants to merge 1 commit intoobra:mainfrom
Closed
fix: resolve ESM/CommonJS conflict in brainstorming server #774#784sarbojitrana wants to merge 1 commit intoobra:mainfrom
sarbojitrana wants to merge 1 commit intoobra:mainfrom
Conversation
Owner
|
Thanks @sarbojitrana! Clean fix — exactly the right approach. Cherry-picked your commit to the dev branch (preserving your authorship). Closing the PR since we applied it directly rather than merging. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #774
Resolves a runtime error in Node.js v25+ where the brainstorming server fails to start due to a module system mismatch.
Problem
The repository is configured with
"type": "module"(ESM), butserver.jsuses CommonJS (require).Node.js v25 enforces ESM strictly, resulting in:
Solution
server.js→server.cjsto explicitly use CommonJSstart-server.shto reference the new fileBefore the fix
After the fix