fix(skills): update plan file checkboxes after completing tasks#808
Open
fix(skills): update plan file checkboxes after completing tasks#808
Conversation
Both executing-plans and subagent-driven-development used only TodoWrite (ephemeral) for progress tracking, leaving all plan file checkboxes as `- [ ]` even after full implementation. Add explicit instructions to update `- [ ]` to `- [x]` in the plan file using the Edit tool after each task completes. This makes the plan file a persistent progress record across sessions. Changes: - executing-plans: add step 5 to update checkboxes after task completion - subagent-driven-development: add Plan File Tracking section, update process diagram node, and update example workflow Fixes obra#789
There was a problem hiding this comment.
Pull request overview
Updates the workflow documentation for plan execution to ensure progress is persisted back into the on-disk plan file (checkboxes), not only tracked in TodoWrite.
Changes:
- Extend the subagent-driven-development process to include updating plan-file checkboxes after completing each task.
- Add a “Plan File Tracking” section and update the example workflow to include the plan-file checkbox update step.
- Update executing-plans to explicitly instruct updating the plan file checkboxes via the Edit tool.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/subagent-driven-development/SKILL.md | Updates the per-task flow diagram and adds explicit guidance + examples for marking plan-file checkboxes complete. |
| skills/executing-plans/SKILL.md | Adds an explicit step to update plan-file checkboxes after marking a task complete. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ## Plan File Tracking | ||
|
|
||
| After marking a task complete in TodoWrite, update the plan file on disk — change `- [ ]` to `- [x]` for all completed steps in that task using the Edit tool. This keeps the plan file as a persistent progress record across sessions. |
Author
There was a problem hiding this comment.
Fixed in 46c3286 — now uses `Edit` tool with backtick formatting.
skills/executing-plans/SKILL.md
Outdated
| 2. Follow each step exactly (plan has bite-sized steps) | ||
| 3. Run verifications as specified | ||
| 4. Mark as completed | ||
| 5. Update the plan file: change `- [ ]` to `- [x]` for completed steps using Edit tool |
Author
There was a problem hiding this comment.
Fixed in 46c3286 — now uses `Edit` tool with backtick formatting.
Address Copilot review feedback — consistent tool name formatting.
obra
added
bug
|
When will this PR be merged and released? I was just about to open a related PR and I found it. 😂 |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #789 —
executing-plansandsubagent-driven-developmentnever updated plan file checkboxes (- [ ]→- [x]), leaving all checkboxes unchecked even after full implementation.Root cause: Both skills used only
TodoWrite(ephemeral, session-scoped) for progress tracking. The plan file on disk was never modified, despitewriting-planspromising checkbox tracking in the plan header.Fix: Add explicit instructions for the orchestrator (not the subagent) to update checkboxes in the plan file using the Edit tool after each task completes.
Changes
skills/executing-plans/SKILL.md— Add step 5: update plan file checkboxes after task completionskills/subagent-driven-development/SKILL.md— Add "Plan File Tracking" section, update process diagram node, update example workflow with checkbox update stepsDesign decision
The orchestrator updates checkboxes (not the implementer subagent), because:
Testing
Verified with a fresh Claude Code instance (
claude -p --plugin-dir <modified-plugin>):- [ ](unchecked)- [x](checked)All 6 task step checkboxes were updated after execution. The remaining
- [ ]is in the plan header (syntax example, not a step).Also verified:
writing-planspromise: "Steps use checkbox syntax for tracking"