add a definition to the {transform} representation of a value#1070
Closed
Fil wants to merge 1 commit intofacet-expandfrom
Closed
add a definition to the {transform} representation of a value#1070Fil wants to merge 1 commit intofacet-expandfrom
Fil wants to merge 1 commit intofacet-expandfrom
Conversation
This was referenced Oct 4, 2022
Closed
… can read that definition and decide that it wants to run the transform, or just use the definition. This allows the mark to decide, for example, if a color is a channel or a constant color. If a channel, then reindexation is applied lazily.
Contributor
Author
|
Let's stay on #1069 so as not to introduce a new property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a mark can read that definition and decide that it wants to run the transform, or just use the definition. This allows the mark to decide, for example, if a color is a channel or a constant color. If a channel, then reindexation is applied lazily.
This makes #1069 lighter, in the sense that channels are expanded lazily, and the mark still gets to decide how it wants to process the original channel definition.