Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
mbostock
reviewed
Apr 11, 2026
mbostock
requested changes
Apr 11, 2026
Member
There was a problem hiding this comment.
I find the checkerboard ugly, but more importantly, it doesn’t match what you see in the chart itself (since charts don’t have a checkerboard background). The use of a checkerboard pattern therefore feels like a technical cue; the reader must apply their knowledge of the checkerboard convention from other applications to say “a ha, this is an opacity encoding.” Often I don’t think the user cares about the distinction between opacity and color, since in practice due to compositing an opacity encoding is a color encoding.
Of course I like that the opacity legend supports CSS4 and dark mode, so we should do that, but I’m going to remove the rest.
mbostock
approved these changes
Apr 11, 2026
This was referenced Apr 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the color legend, to
have a checkerboarda test showing the
32 new features: