Merged
Conversation
Contributor
|
Do we really want to expose all of these via flags? 🤔 |
Member
Author
|
@metalmatze Yes, happy to remove flags 👍 We have too many of them. |
squat
reviewed
Apr 3, 2020
squat
reviewed
Apr 3, 2020
kakkoyun
force-pushed
the
timeouts
branch
2 times, most recently
from
f520d7f to
5fc0a73
Compare
squat
reviewed
Apr 15, 2020
squat
reviewed
Apr 15, 2020
squat
reviewed
Apr 15, 2020
Member
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
One last set of nits for the comments and then let's merge :)
Member
|
let's squash the commit :) |
periklis
pushed a commit
to periklis/api
that referenced
this pull request
Jul 9, 2021
*: bump kube-thanos
philipgough
pushed a commit
to philipgough/api
that referenced
this pull request
Feb 1, 2024
* handle the path for different write backend Signed-off-by: Marco llan@redhat.com * fix test error Signed-off-by: Marco llan@redhat.com * fix test error Signed-off-by: Marco llan@redhat.com
philipgough
pushed a commit
to philipgough/api
that referenced
this pull request
Feb 10, 2026
Copy LICENSE file to /licenses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all the possible knobs to be more flexible for the adjustments.
Also changes the default values.