NETOBSERV-1020 Fix empty namespace list#512
Closed
jotak wants to merge 1 commit intoobservatorium:mainfrom
Closed
Conversation
cf observatorium/opa-openshift#18 We need to prevent attempts to run queries when the matchers list exists but is empty, which corresponds to having 0 allowed namespaces
jotak
commented
May 5, 2023
| } | ||
|
|
||
| if len(matchersInfo.Matchers) == 0 { | ||
| httperr.PrometheusAPIError(w, "empty authorization label matchers", http.StatusInternalServerError) |
Contributor
Author
There was a problem hiding this comment.
We might do something different than returning such an error. Ideally, we should not run any loki query but directly return an empty result set. (I need to check how to do that...)
Contributor
Author
|
closing: amended the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf observatorium/opa-openshift#18
We need to prevent attempts to run queries when the matchers list exists but is empty, which corresponds to having 0 allowed namespaces