chore: simplify init functions#863
Merged
philipgough merged 1 commit intoobservatorium:mainfrom Jan 15, 2026
Merged
Conversation
Contributor
Author
|
The generate failure is being addressed in #864 |
This commit removes the init() function which initializes the `providerFactories` variable. This mechanism is fragile because it assumes that no other init() function will call `onboardNewProvider()` before the map is initialized. In practice the Go compiler evaluates the init() functions from a single package in lexical filename order meaning that we could have a Go file evaluated before `authentication/authentication.go` in the future. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
fix-dangerous-init
branch
from
66368cb to
c6e1c44
Compare
philipgough
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the init() function which initializes the
providerFactoriesvariable. This mechanism is fragile because it assumes that no other init() function will callonboardNewProvider()before the map is initialized. In practice the Go compiler evaluates the init() functions from a single package in lexical filename order meaning that we could have a Go file evaluated beforeauthentication/authentication.goin the future.