Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Flash Redirect Helpers + ResponseContext
Summary
Adds typed redirect helpers to
BaseController(redirectWithSuccess,redirectWithError, etc.) and introducesResponseContextto eliminatereq, resboilerplate in flash redirects.Changes
1. ResponseContext — ThreadLocal for Response
Added:
livecomponents/http/ResponseContext.javaRequestContextpattern:ThreadLocal<Response>withset(),get(),clear()2. SessionMiddleware — wire ResponseContext
Modified:
SessionMiddleware.javaResponseContext.set(res)added alongsideRequestContext.set(req)inhandle()ResponseContext.clear()added to the staticclear()method to prevent memory leaks3. BaseController — typed flash redirect helpers
Modified:
BaseController.javaredirectWithFlash()now usesRequestContext.get()/ResponseContext.get()instead of the non-existentSpark.request()/Spark.response()redirectWithSuccess(),redirectWithError(),redirectWithWarning(),redirectWithInfo()spark.Requestwas imported twice,import static spark.Spark.*was unused)Breaking Changes
redirectWithFlash(Request req, Response res, String type, String message, String location)signature changed toredirectWithFlash(String type, String message, String location). Any existing calls passingreq, resmust be updated to drop those parameters.