Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser dock functions in the frontend api #7638

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Oct 22, 2022

Description

Depends on:

Add function to the frontend API:

  • Add obs_frontend_is_browser_available() to check if OBS Studio have the browser feature (built with obs-browser, not running under Wayland).
  • Add obs_frontend_add_browser_dock() to add browser docks through the frontend API.
  • Add obs_frontend_change_browser_dock_url() that allows to change the URL of an already existing browser dock (not a custom browser dock from the UI).

Motivation and Context

Finally land this feature.

Being able to use the browser from the frontend API is also a requirement of obsproject/rfcs#39.

How Has This Been Tested?

Added a browser dock through the API.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added Enhancement Improvement to existing functionality New Feature New feature or plugin labels Oct 22, 2022
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 2 times, most recently from 91a2b8d to 24b11a0 Compare October 22, 2022 16:19
@tytan652 tytan652 added this to the OBS Studio 29.1 milestone Nov 20, 2022
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 2 times, most recently from 8308cd3 to 9817cb8 Compare January 20, 2023 20:39
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 2 times, most recently from d76d44f to 1c06c07 Compare January 29, 2023 13:05
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 3 times, most recently from d9aa6b1 to 7c77658 Compare February 20, 2023 11:43
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 2 times, most recently from 0264422 to 2ffe1b6 Compare February 27, 2023 12:25
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 2 times, most recently from ab0facc to 4c06f3f Compare March 11, 2023 09:27
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 3 times, most recently from 8ebc9b4 to 31eedc7 Compare March 21, 2023 12:03
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 3 times, most recently from 5abe9c6 to 7ce8b6e Compare May 3, 2023 06:54
@tytan652 tytan652 force-pushed the browser_dock_frontend_api branch 2 times, most recently from f86930a to 30897f5 Compare May 31, 2023 06:30
@tytan652 tytan652 marked this pull request as ready for review June 3, 2023 23:53
@tytan652 tytan652 marked this pull request as draft June 20, 2023 08:53
@tytan652
Copy link
Collaborator Author

tytan652 commented Jul 8, 2023

Might be superseded by #9220 browser related API for service integrations plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality New Feature New feature or plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants