add option to raise an exception if vcr is used and it's not needed#7
Merged
add option to raise an exception if vcr is used and it's not needed#7
Conversation
fa32289 to
b784c4f
Compare
this way it becomes more obvious if decorator is used where it shouldnt be..
b784c4f to
08b9f72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it becomes more obvious if decorator is used where it should not be.. otherwise it's sometimes hard to know why tape files are not generated for decorated functions when the warning message is suppressed..
In obspy this can then look like:
Otherwise test passes without a VCR tape generated and it's not immediately obvious what's going wrong..