Skip to content

Optimize: Avoid GroupBy when unnessesary #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obvEve merged 2 commits into from
Apr 29, 2026
Merged

Optimize: Avoid GroupBy when unnessesary #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbfaa93
Optimize: Avoid GroupBy when unnessary
obvEve Apr 28, 2026
8d986a3
optimize: Remove unncessary harmony patch
obvEve Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion SecretAPI/Features/Effects/CustomPlayerEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public abstract class CustomPlayerEffect : StatusEffectBase
[CallOnLoad]
internal static void Initialize()
{
SecretApi.Harmony.PatchCategory(nameof(CustomPlayerEffect), SecretApi.Assembly);
EffectsToRegister.Add(typeof(Energized));
EffectsToRegister.Add(typeof(Depleted));

Expand Down
22 changes: 14 additions & 8 deletions SecretAPI/Features/UserSettings/CustomSetting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,20 +300,26 @@ public static void SendSettingsToPlayer(Player player, int? version = null)
playerSettings.Add(playerSpecific);
}

List<ServerSpecificSettingBase> ordered = ListPool<ServerSpecificSettingBase>.Shared.Rent();
foreach (IGrouping<CustomHeader, CustomSetting> grouping in playerSettings.GroupBy(static setting => setting.Header))
if (playerSettings.Count != 0)
{
ordered.Add(grouping.Key.Base);
ordered.AddRange(grouping.Select(static setting => setting.Base));
}
List<ServerSpecificSettingBase> ordered = ListPool<ServerSpecificSettingBase>.Shared.Rent();
foreach (IGrouping<CustomHeader, CustomSetting> grouping in playerSettings.GroupBy(static setting => setting.Header))
{
ordered.Add(grouping.Key.Base);
ordered.AddRange(grouping.Select(static setting => setting.Base));
}

if (ServerSpecificSettingsSync.DefinedSettings != null)
ordered.AddRange(ServerSpecificSettingsSync.DefinedSettings);

ServerSpecificSettingsSync.SendToPlayer(player.ReferenceHub, ordered.ToArray(), version);
ServerSpecificSettingsSync.SendToPlayer(player.ReferenceHub, ordered.ToArray(), version);
ListPool<ServerSpecificSettingBase>.Shared.Return(ordered);
}
else
{
ServerSpecificSettingsSync.SendToPlayer(player.ReferenceHub, ServerSpecificSettingsSync.DefinedSettings, version);
}

ListPool<CustomSetting>.Shared.Return(playerSettings);
ListPool<ServerSpecificSettingBase>.Shared.Return(ordered);
}

/// <summary>
Expand Down
Loading