feat: Workspace 1064

[SKairinos]

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 77.40000% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.11%. Comparing base (2499d9f) to head (0ec24d0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
codeforlife/user/models/student.py	57.50%	17 Missing ⚠️
codeforlife/user/models/klass.py	70.00%	15 Missing ⚠️
codeforlife/user/models/school.py	62.50%	15 Missing ⚠️
codeforlife/user/models/other.py	87.15%	14 Missing ⚠️
codeforlife/user/models/teacher/teacher.py	67.44%	14 Missing ⚠️
setup.py	0.00%	11 Missing ⚠️
codeforlife/user/models/teacher/school.py	86.04%	6 Missing ⚠️
codeforlife/user/models/user/user.py	86.66%	4 Missing ⚠️
codeforlife/user/models/teacher/admin_school.py	82.35%	3 Missing ⚠️
...odeforlife/user/models/teacher/non_admin_school.py	85.71%	2 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   73.58%   76.11%   +2.53%     
==========================================
  Files         170      191      +21     
  Lines        4384     5502    +1118     
==========================================
+ Hits         3226     4188     +962     
- Misses       1158     1314     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[faucomte97]

@faucomte97 reviewed 67 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on SKairinos).

---

codeforlife/user/models/klass.py line 47 at r2 (raw file):

    """Manager for Class model."""

    def all_members(self, user):

This actually doesn't look like it's used anywhere. Add a TODO to remove plz

---

codeforlife/user/models/klass.py line 127 at r2 (raw file):

    @property
    def active_game(self):

From the old aimmo days. Add a TODO to remove plz

---

codeforlife/user/models/other.py line 253 at r2 (raw file):

    )  # Same as User model
    # TODO: Make not nullable once data has been transferred
    _invited_teacher_first_name = models.BinaryField(null=True, blank=True)

Remove the 3 fields that start with _ which were for our original approach

[faucomte97]

@faucomte97 reviewed 8 files and all commit messages, and resolved 3 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on SKairinos).

[SKairinos]

@SKairinos made 2 comments.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on SKairinos).

---

codeforlife/user/models/klass.py line 47 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

This actually doesn't look like it's used anywhere. Add a TODO to remove plz

deleted

---

codeforlife/user/models/klass.py line 127 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

From the old aimmo days. Add a TODO to remove plz

deleted

[faucomte97]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on SKairinos).

[faucomte97]

@faucomte97 made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on SKairinos).