Fix some trivial nits #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is workspace-friendly. jbuilder clean needs Jbuilder >= 1.0+beta10; see https://github.com/janestreet/jbuilder/blob/604e599e4e9471bdfc14ccfa88e116d601874242/CHANGES.md#10beta10-08062017
Including avoiding one over-long line.
It is auto-generated by Jbuilder
To keep it local, blame-friendly, etc.
Collaborator
|
Sorry for the delay, I'd forgotten this was here. I'm not keen on the change to the warnings. In general, I like to use roughly the set used by jbuilder by default. I'm fine with turning on some of the others, but I'd like them to be turned on explicitly (e.g. |
Contributor
|
Idem, completely forgot this PR. |
Contributor
Author
|
Made obsolete by #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.