autogen: add project_name/PROJECT_NAME#181
Merged
jeromemaloberti merged 1 commit intoocaml-obuild:masterfrom Mar 21, 2019
Merged
autogen: add project_name/PROJECT_NAME#181jeromemaloberti merged 1 commit intoocaml-obuild:masterfrom
jeromemaloberti merged 1 commit intoocaml-obuild:masterfrom
Conversation
When generating path_generated.ml, and obuild_macros.h, output also the project name as variable/define. This way, other parts of the project do not need to hardcode the project name.
Contributor
|
Thank you for your contribution. |
Contributor
Author
Does that mean the PR is accepted, and merged? Because I do not see it in master, yet. |
Contributor
|
Sorry, I forgot to merge it before closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating
path_generated.ml, andobuild_macros.h, output also the project name as variable/define. This way, other parts of the project do not need to hardcode the project name.