Skip to content

fix: bootstrap#11636

Merged
nojb merged 2 commits intoocaml:mainfrom
Alizter:fix-bootstrap
Apr 17, 2025
Merged

fix: bootstrap#11636
nojb merged 2 commits intoocaml:mainfrom
Alizter:fix-bootstrap

Conversation

@Alizter
Copy link
Collaborator

@Alizter Alizter commented Apr 17, 2025

In 153fcd1 the filter on external libraries was flipped. This fixes that issue.

This fixes issues with bootstrap on newer OCaml versions.

Thanks @nojb!

In 153fcd1 the filter on external libraries was flipped. This fixes that
issue.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Copy link
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nojb nojb merged commit 0764b1a into ocaml:main Apr 17, 2025
22 of 23 checks passed
@Alizter Alizter deleted the fix-bootstrap branch April 17, 2025 21:59
Sudha247 pushed a commit to Sudha247/dune that referenced this pull request Jul 23, 2025
In 153fcd1 the filter on external libraries was flipped. This fixes that
issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants