simplify implementation of dune exec further #11641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
refactor-exec
branch
4 times, most recently
from
e187e24 to
768fb1b
Compare
Collaborator
Author
|
The test which signals a segfault seems to crash out in the ubuntu CI but seems fine on macos and my machine (nixos). Not sure what is happening there. |
Member
|
@gridbugs can you review this one? |
We test how `dune exec` interacts with failing programs. Signed-off-by: Ali Caglayan <alizter@gmail.com>
There is no good reason for this module to exist. We explode it's contents and simplify the implementation of dune exec. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
gridbugs
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We simplify the implementation of
dune execfurther and nowdune execanddune exec -wshare the same implementation.One difference with before (which can be observed in the tests) is that
arg[0]is now set to an absolute path. This is still valid within thearg[0]convention, but we could think about changing it back to a relative path.