fix: add eta-expansions for OxCaml compatibility#13342
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Jan 17, 2026
Merged
Conversation
Add eta-expansion to partial function applications to work around value restriction issues with oxcaml. Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Member
|
Just a sanity check: you are certain that this is an issue with our code and not a bug in oxcaml? |
Member
Author
|
It's a known backwards-incompatible change in oxcaml atm; https://oxcaml.org/documentation/stack-allocation/pitfalls/#partial-applications-with-local-parameters |
Member
|
Thanks. It's just a bit suspicious that this started recently. |
Alizter
pushed a commit
to Alizter/dune
that referenced
this pull request
Feb 6, 2026
Add eta-expansion to partial function applications to work around value restriction issues with oxcaml. backport: keep only v1.ml eta-expansion fix Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
pushed a commit
to Alizter/dune
that referenced
this pull request
Feb 6, 2026
Add eta-expansion to partial function applications to work around value restriction issues with oxcaml. backport: keep only v1.ml eta-expansion fix Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
added a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add eta-expansion to partial function applications to work around value restriction issues with oxcaml.