Test that shows that rev-store is not validated correctly #13392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Collaborator
Author
Leonidas-from-XIV
added a commit
that referenced
this pull request
Jan 20, 2026
…13396) In `rev_store.ml` we currently try to create the rev-store folder and if it exists then we assume that it is a bare repo. This is not necessarily the case and if the folder is e.g. empty (because a previous `init --bare` failed) the rev-store is permanently bricked with no way to recover (bar the user removing it but it is unclear from the error what the user can do, as `git` points at somewhere else). Noticed this behavior when pairing on a strange test failure on #13297 with @Alizter and paired with @Sudha247 to create a repro case. This PR is a variant of #13392 which reproduces the same behavior using a different approach which does not require the changes from #13297. Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
rev_store.mlwe currently try to create therev-storefolder and if it exists then we assume that it is a bare repo. This is not necessarily the case and if the folder is e.g. empty (because a previousinit --barefailed) the rev-store is permanently bricked with no way to recover (bar the user removing it).Currently needs #13297.