slang: test and improve the simplification of slang#13642
Merged
Alizter merged 8 commits intoocaml:mainfrom Feb 18, 2026
Merged
slang: test and improve the simplification of slang#13642Alizter merged 8 commits intoocaml:mainfrom
Alizter merged 8 commits intoocaml:mainfrom
Conversation
rgrinberg
reviewed
Feb 18, 2026
rgrinberg
approved these changes
Feb 18, 2026
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
…constants Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
slang-simplify
branch
from
83d7f86 to
096e334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is two-fold, firstly to document the current simplification behaviour and secondly to improve it.
The first commit in this PR adds tests for various cases we would expect slang to simplify. The subsequent cases all target a particular case and allow it to happen.
This will be used in
in order to simplify eagerly evaluated expressions and will be more useful generally to reduce the duplication and complexity of portable lock directories.