fix(pkg): set OPAMSWITCH in package build environment#13888
Merged
Alizter merged 1 commit intoocaml:mainfrom Mar 23, 2026
Merged
fix(pkg): set OPAMSWITCH in package build environment#13888Alizter merged 1 commit intoocaml:mainfrom
Alizter merged 1 commit intoocaml:mainfrom
Conversation
rgrinberg
approved these changes
Mar 23, 2026
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
A test for this would be good.
Fixes ocaml#13887 The relocatable compiler's process.sh script references $OPAMSWITCH. Since dune is not opam, set it to a value that allows the script to progress. It doesn't matter if this switch actually exists, since other mechanisms in the script will cause it to abort early and avoid cloning the compiler switch. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-vspstntrvqyz
branch
from
2e16945 to
c8a8ff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPAMSWITCHin dune when building compiler #13887The relocatable compiler's (OCaml 5.5) process.sh script references $OPAMSWITCH. Since dune is not opam, set it to a value that allows the script to progress. It doesn't matter if this switch actually exists, since other mechanisms in the script will cause it to abort early and avoid cloning the compiler switch.
https://github.com/ocaml/ocaml/blob/trunk/tools/opam/process.sh
This is now being used in the opam file for the compiler:
https://github.com/ocaml/opam-repository/blob/63b7ba71be83567e54bb667df0f2bb374d74fb61/packages/ocaml-compiler/ocaml-compiler.5.5.0~alpha1/opam#L62