fix(time): old macos fallback

[Alizter]

No description provided.

[barracuda156]

There is another instance here:

dune/otherlibs/stdune/src/wait4_stubs.c

Line 81 in d2120ac

clock_gettime(CLOCK_REALTIME, &tp);

[rgrinberg]

It's bad enough to add these ifdefs, I don't think they should be copy pasted. You should extract the definition of this function into a header.

[Alizter]

@rgrinberg Are you suggesting I put the time stubs in a foreign archive or something?

[barracuda156]

@Alizter The patch from 352ccf2 worked.

[barracuda156]

This build works on 10.6 now.

[rgrinberg]

@rgrinberg Are you suggesting I put the time stubs in a foreign archive or something?

That would work, but it would be overkill. Instead, I'm suggesting that you put the implementation inside of a header file that you can include in both C sources. As long as the implementation is static, it should be fine.

[rgrinberg]

@barracuda156 by the way, what version of OCaml are you using?

[barracuda156]

@barracuda156 by the way, what version of OCaml are you using?

4.14.3

OCaml 5 is not available in MacPorts (or in my fork). It is also not present in OpenBSD ports etc.

[Alizter]

@rgrinberg I've introduced a common header with all the platform specific timing code.

[barracuda156]

Thank you very much!