Add test for promoting over a running binary#14173
Merged
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom Apr 17, 2026
Merged
Add test for promoting over a running binary#14173Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Conversation
Leonidas-from-XIV
requested changes
Apr 13, 2026
robinbb
force-pushed
the
fix-3484-promote-running-binary
branch
2 times, most recently
from
fc5a98e to
87b7222
Compare
Collaborator
Author
|
@Leonidas-from-XIV Back to you for review. I have addressed each concern. |
Leonidas-from-XIV
requested changes
Apr 15, 2026
robinbb
force-pushed
the
fix-3484-promote-running-binary
branch
2 times, most recently
from
ba80782 to
d88629c
Compare
Closes ocaml#3484 Promotion of a binary that is currently running used to crash with `Sys_error("Text file busy")`. This was fixed by the refactoring of `artifact_substitution.ml` to use atomic copy (write to temp file, then rename), since `rename` replaces the directory entry while the running process keeps its open file descriptor. Add a regression test to prevent this from breaking again. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
fix-3484-promote-running-binary
branch
from
d88629c to
6529813
Compare
Collaborator
Author
|
@Leonidas-from-XIV The CI was briefly failing due to an unrelated problem, but is now green again. |
Leonidas-from-XIV
approved these changes
Apr 17, 2026
Collaborator
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks good to me; thanks for addressing all the concerns!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3484
Promoting a binary via
(promote (into ...))while it is running used tocrash with
Sys_error("Text file busy")and a raw stacktrace. This wasfixed by the refactoring of
artifact_substitution.mlto use atomic copy(write to temp file, then
rename), sincerenamereplaces the directoryentry while the running process keeps its open file descriptor.
This PR adds a regression test to prevent this from breaking again.
New test added:
promote/promote-over-running-binary.tpasses