pkg: prevent user from setting with-test variable#9339
Merged
gridbugs merged 1 commit intoocaml:mainfrom Dec 1, 2023
Merged
Conversation
rgrinberg
approved these changes
Dec 1, 2023
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
It's OK to add stuff like this, but I'd recommend that we focus on expanding the functionality rather than implementing safety belts. We're gonna have plenty of ideas on what to do here once we get some real world experience from users in the upcoming alpha releases.
This variable is used internally by the solver to implement dune's policy of including test dependencies of local packages only. We may want to allow users some degree of control over this process eventually but that should come from a higher-level feature than setting the with-test variable directly. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
prevent-with-test-var
branch
from
129f633 to
f2b6aef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable is used internally by the solver to implement dune's policy of including test dependencies of local packages only. We may want to allow users some degree of control over this process eventually but that should come from a higher-level feature than setting the with-test variable directly.