Refactor index caching. Get rid of the stamping. #1990
Merged
+80
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam923
approved these changes
Nov 6, 2025
Contributor
liam923
left a comment
liam923
left a comment
There was a problem hiding this comment.
Thanks, this change definitely seems like an improvement and makes the cache a lot easier to reason about.
Contributor
Maybe this discussion belongs elsewhere, but could you elaborate on this? It seems to me that making |
Collaborator
Author
|
Thanks for the review.
That sounds reasonable too. I will think about it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liam923 not what you expected, but at least the use of the cache is clearer now. I don't know why I opted for the imperative stamped hashtbl in the initial version. This version relies on sharing and integrates much more naturally with the typer cache.
If the next step is to have "lazy" indexing, I think the most sensible approch would be to add a pipeline phase after typing.