Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ unreleased
- Fix record field autocompletion (#2028)
- Signature help should not loop over the parameters once it is finished (#2023)
- Add a reproduction case for #1214, the issue has been resolved before (#2022)
- Add reproduction case for #1763 but it is not failing anymore (#2021)

merlin 5.6.1
============
Expand Down
33 changes: 33 additions & 0 deletions tests/test-dirs/issue1763.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
$ $MERLIN single type-enclosing -position 8:0 <<EOF | jq '.value[].type'
> module Foo = struct
> let hidden = 3
> end
>
> include struct
> open Foo
> let visible = 4
> end
> EOF
"sig val visible : int end"

$ $MERLIN single type-enclosing -position 7:0 <<EOF | jq '.value[].type'
> include struct
> module Foo = struct
> let hidden = 3
> end
> open Foo
> let visible = 4
> end
> EOF
"sig module Foo : sig val hidden : int end val visible : int end"

This was failing in the issue but appears to not fail anymore with the actual merlin
$ $MERLIN single type-enclosing -position 6:0 <<EOF | jq '.value[].type'
> include struct
> open struct
> let hidden = 3
> end
> let visible = 4
> end
> EOF
"sig val visible : int end"