Skip to content

Define PATH_MAX to 4096 if undefined #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voodoos merged 2 commits into from
Mar 16, 2026
+7 −0
Merged

Define PATH_MAX to 4096 if undefined #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac27668
Define PATH_MAX to 8192 if undefined
Feb 26, 2026
8b43501
Add a changelog entry for #2039
voodoos Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ unreleased
- Fix bugs on signature help about labelled and optional parameters (#2032)
- Add `-end-position` parameter for `enclosing` (#2029)
- Signature help should appear even if the 'in' is not written (#2036)
+ merlin binary
- Define PATH_MAX to 4096 if undefined (eg. hurd) (#2039)
+ tests
- Add a reproduction case for #1214, the issue has been resolved before (#2022)
- Add reproduction case for #1763 but it is not failing anymore (#2021)
Expand Down
5 changes: 5 additions & 0 deletions src/frontend/ocamlmerlin/ocamlmerlin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ static void failwith(const char *msg)
exit(EXIT_FAILURE);
}

#ifndef PATH_MAX
/* PATH_MAX is undefined on e.g. Hurd */
#define PATH_MAX 8192
#endif

#ifdef _WIN32
#define PATHSZ (MAX_PATH+1)
#define SOCKSZ (MAX_PATH+1)
Expand Down