Html indent #568
Html indent #568
Conversation
| | `Class of signature * ClassName.t | ||
| | `ClassType of signature * ClassTypeName.t ] | ||
|
|
||
| type leaf = [ module_ | type_ ] |
There was a problem hiding this comment.
What about classes, substs and others ?
(Would help move the assert false from render_resolved_fragment)
There was a problem hiding this comment.
this refers to the type of the substitution - ie, X with module Y=Z or X with type t = u -- so only module or type required.
There was a problem hiding this comment.
Thanks, I got confused by the type t below. Why does it include everything ?
There was a problem hiding this comment.
that's the union one, helpful for printers and the like. it's quite handy to have just the leaf one so we don't have to deal with the Root constructor unnecessarily
| let indent = | ||
| let doc = "Format the output HTML files with indentation" in | ||
| Arg.(value & flag (info ~doc [ "indent" ])) |
There was a problem hiding this comment.
What about enabling it by default without exposing the option ? Whitespaces compress well and indented output is always nicer to look at.
There was a problem hiding this comment.
could do - I've got no strong views on this. I've added it because my previous script was just running things through html tidy, and the larger my test set got the slower the tidying got!
| let sg = Type_of.signature env m in | ||
| Module (signature env (id :> Id.Signature.t) sg) | ||
| | Pack _ -> failwith "Unhandled content" | ||
| | Pack p -> Pack p |
There was a problem hiding this comment.
How hard would it be to actually compile packs ?
There was a problem hiding this comment.
I've not even looked into it to be honest - not many packages use packing right now, but the one I have installed was causing my tests to fail!
jonludlam
force-pushed
the
html-indent
branch
from
d8e79c7 to
ce98388
Compare
|
As @Julow said, It should probably be enabled by default. The performance cost is probably negligible, as is the size cost after compression. |
3 participants
Add a parameter to
html-generateto format the output nicely - useful for diffingAlso this no longer causes exceptions when processing 'packed' compilation units.