-
Notifications
You must be signed in to change notification settings - Fork 101
Html indent #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html indent #568
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,7 +64,7 @@ and content env id = | |
| | Module m -> | ||
| let sg = Type_of.signature env m in | ||
| Module (signature env (id :> Id.Signature.t) sg) | ||
| | Pack _ -> failwith "Unhandled content" | ||
| | Pack p -> Pack p | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How hard would it be to actually compile packs ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've not even looked into it to be honest - not many packages use packing right now, but the one I have installed was causing my tests to fail! |
||
|
|
||
| and value_ env parent t = | ||
| let open Value in | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about enabling it by default without exposing the option ? Whitespaces compress well and indented output is always nicer to look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could do - I've got no strong views on this. I've added it because my previous script was just running things through
html tidy, and the larger my test set got the slower the tidying got!