OpamFilename.might_escape ~sep:Unspecified: Fix escape detection on Windows#6896
Open
kit-ty-kate wants to merge 1 commit intoocaml:masterfrom
Open
OpamFilename.might_escape ~sep:Unspecified: Fix escape detection on Windows#6896kit-ty-kate wants to merge 1 commit intoocaml:masterfrom
kit-ty-kate wants to merge 1 commit intoocaml:masterfrom
Conversation
rjbou
reviewed
Apr 15, 2026
Collaborator
rjbou
left a comment
rjbou
left a comment
There was a problem hiding this comment.
Tha change itself is lgtm, it worth having a test, but i don't have an idea on which one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function with this particular parameter is unused in the code currently so this is only an issue for library users at the moment.