Add regression test for aborted local install leaving half-pinned pkgs#6922
Merged
kit-ty-kate merged 1 commit intoMay 4, 2026
Merged
Conversation
NathanReb
force-pushed
the
add-reftest-abort-install-dot-slash
branch
2 times, most recently
from
98bd60b to
8037381
Compare
kit-ty-kate
approved these changes
May 4, 2026
kit-ty-kate
reviewed
May 4, 2026
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
kit-ty-kate
force-pushed
the
add-reftest-abort-install-dot-slash
branch
from
8037381 to
fcd316a
Compare
Member
|
Ignoring the failure on Windows (see #6890). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to show what happens when an install containing local packages is aborted or fails mid run and what packages are still pinned afterwards.
At the moment it only shows that it leaves the switch in a state that
opam pin listcannot handle and it crashes with a terriblechdirerror.After #6910,
opam pin listshould work and it will show that packages pinned during the aborted install are left as such, which is something that we'd like to change and that I'll fix in a separate PR.